Add test coverage for print-pgtle target (issue #21) - #73
Merged
jnasbyupgrade merged 1 commit intoSep 8, 2026
Merged
Conversation
Companion tests for pgxntool's new `make print-pgtle` target (Postgres-Extensions/pgxntool@4259313): - test/sequential/04-pgtle.bats: PGXNTOOL_PGTLE_TARGET_VERSION selects and prints the matching pg_tle/ directory's SQL exactly; an older target version maps to the correct older range; a bare PGTLE_VERSION env var does not leak into the new variable; a regression test proving --no-print-directory is required to avoid GNU Make's "Entering directory"/"Leaving directory" stdout pollution on recursive invocation - test/standard/pgtle-install.bats: falls back to the installed pg_tle version when no target version is set; errors cleanly when pg_tle isn't installed and no target version is set Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
1 task
jnasbyupgrade
marked this pull request as ready for review
September 8, 2026 20:38
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool
that referenced
this pull request
Sep 8, 2026
Adds a `make print-pgtle` target that prints the generated pg_tle registration SQL for each extension to stdout instead of running it, so a consumer can build a combined multi-extension install file: ``` $(MAKE) --no-print-directory -C ../deps/cat_tools print-pgtle >> pgtle-all.sql ``` - Depends on `pgtle` (regenerates SQL first, like `run-pgtle`). - New `PGXNTOOL_PGTLE_TARGET_VERSION` variable (an actual pg_tle version like `1.5.2`, not a range) selects the directory; falls back to the installed pg_tle version if unset. ## Companion PR pgxntool-test: Postgres-Extensions/pgxntool-test#73 Fixes #21. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion tests for pgxntool's new
make print-pgtletarget (Postgres-Extensions/pgxntool#94).test/sequential/04-pgtle.bats:PGXNTOOL_PGTLE_TARGET_VERSIONselects and prints the matchingpg_tle/directory's SQL exactly; an older target version maps to the correct older range; a barePGTLE_VERSIONenv var does not leak into the new variable; a regression test proving--no-print-directoryis required to avoid GNU Make'sEntering directory/Leaving directorystdout pollution on recursive invocation.test/standard/pgtle-install.bats: falls back to the installed pg_tle version when no target version is set; errors cleanly when pg_tle isn't installed and no target version is set.Companion PR
pgxntool: Postgres-Extensions/pgxntool#94
Test plan